13
3
Fork 0
Wiki Issues 89 resources competences Projects 8 Code Pull Requests Releases Activity
Browse Source

Set the initial commit status to Success otherwise it will always be Pending (#10317) 

The commit status code has a bug whereby setting the initial status to Pending means you can never have the status of Success - it should be set to Success.
tags/v1.10.5
zeripath 5 years ago committed by GitHub
parent
314740e215
commit
e96f3542d0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 2
      services/pull/commit_status.go

2
services/pull/commit_status.go
Unescape View File

@ -23,7 +23,7 @@ func MergeRequiredContextsCommitStatus(commitStatuses []*models.CommitStatus, re
return structs.CommitStatusSuccess
}
var returnedStatus = structs.CommitStatusPending
var returnedStatus = structs.CommitStatusSuccess
for _, ctx := range requiredContexts {
var targetStatus structs.CommitStatusState
for _, commitStatus := range commitStatuses {

Write Preview
Loading…
Cancel
Save