Platform_Mirocod

7183 Commits

14 Branches

154 Tags

505 MiB

Tree: 05143768d0

Commit Graph

Author	SHA1	Message	Date
Lunny Xiao	2d213b64d1	use native golang SSH library but ssh-keygen when enable built-in SSH server to remove dependent on that command lines (#5976 ) * use native golang SSH library but ssh-keygen when enable built-in SSH server to remove dependent on that command lines * fix tests and add comment head	6 years ago
zeripath	01c10a951b	Fix ssh deploy and user key constraints (#1357 ) (#5939 ) 1. A key can either be an ssh user key or a deploy key. It cannot be both. 2. If a key is a user key - it can only be associated with one user. 3. If a key is a deploy key - it can be used in multiple repositories and the permissions it has on those repositories can be different. 4. If a repository is deleted, its deploy keys must be deleted too. We currently don't enforce any of this and multiple repositories access with different permissions doesn't work at all. This PR enforces the following constraints: - [x] You should not be able to add the same user key as another user - [x] You should not be able to add a ssh user key which is being used as a deploy key - [x] You should not be able to add a ssh deploy key which is being used as a user key - [x] If you add an ssh deploy key to another repository you should be able to use it in different modes without losing the ability to use it in the other mode. - [x] If you delete a repository you must delete all its deploy keys. Fix #1357	6 years ago

Author

SHA1

Message

Date

Lunny Xiao

2d213b64d1

use native golang SSH library but ssh-keygen when enable built-in SSH server to remove dependent on that command lines (#5976 )

* use native golang SSH library but ssh-keygen when enable built-in SSH server to remove dependent on that command lines

* fix tests and add comment head

6 years ago

zeripath

01c10a951b

Fix ssh deploy and user key constraints (#1357 ) (#5939 )

1. A key can either be an ssh user key or a deploy key. It cannot be both.
2. If a key is a user key - it can only be associated with one user.
3. If a key is a deploy key - it can be used in multiple repositories and the permissions it has on those repositories can be different.
4. If a repository is deleted, its deploy keys must be deleted too.

We currently don't enforce any of this and multiple repositories access with different permissions doesn't work at all. This PR enforces the following constraints:

- [x] You should not be able to add the same user key as another user
- [x] You should not be able to add a ssh user key which is being used as a deploy key
- [x] You should not be able to add a ssh deploy key which is being used as a user key
- [x] If you add an ssh deploy key to another repository you should be able to use it in different modes without losing the ability to use it in the other mode.
- [x] If you delete a repository you must delete all its deploy keys.

Fix #1357

6 years ago

2 Commits (05143768d0948d3f5e24aa5b87b68ee2ae9a7e6f)